Conversation
vjik
commented
Sep 12, 2026
vjik
commented
Member
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
| Tests pass? | ✔️ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
============================================
+ Coverage 93.96% 94.58% +0.62%
+ Complexity 381 373 -8
============================================
Files 59 59
Lines 1010 978 -32
============================================
- Hits 949 925 -24
+ Misses 61 53 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The declared breaking cleanup is consistently implemented across dispatchers, usages, and tests without unresolved defects.
Pull request overview
Simplifies middleware dispatchers by making configuration constructor-only and immutable.
Changes:
- Removes fluent middleware mutation and inspection APIs.
- Makes dispatcher configuration readonly.
- Updates unit tests to pass middleware through constructors.
File summaries
| File | Description |
|---|---|
src/Middleware/Push/PushMiddlewareDispatcher.php |
Makes configuration immutable and removes mutators. |
src/Middleware/Consume/ConsumeMiddlewareDispatcher.php |
Removes runtime middleware replacement APIs. |
src/Middleware/FailureHandling/FailureMiddlewareDispatcher.php |
Initializes immutable pipeline definitions in the constructor. |
tests/Unit/Middleware/Push/MiddlewareDispatcherTest.php |
Updates push dispatcher construction tests. |
tests/Unit/Middleware/Consume/MiddlewareDispatcherTest.php |
Updates consume dispatcher construction tests. |
tests/Unit/Middleware/FailureHandling/MiddlewareDispatcherTest.php |
Updates failure dispatcher construction tests. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.