Remove $retryProducer from WorkerInterface::process() - #336
Merged
Conversation
vjik
commented
Sep 11, 2026
vjik
commented
Member
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
| Tests pass? | ✔️ |
It was only ever supplied by `SynchronousPushHandler`, so that a message failed under `SyncQueueProducer` could be re-queued into the producer that executed it. With no broker behind that producer, such a retry is an immediate recursive re-execution in the same call stack: it blocks the caller for the whole attempt budget, grows the stack by one frame per attempt, and silently drops the backoff, since `DelayEnvelope` needs an adapter to be honored. Retry destinations are now resolved uniformly in both modes: an explicit `targetQueue`, or `QueueProducerProviderInterface` keyed by the execution queue name. When neither is configured, retry fails with `InvalidQueueConfigException` instead of degrading silently. `SynchronousPushHandler` now takes the queue name instead of the producer, which also removes the self-reference from `SyncQueueProducer`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #336 +/- ##
============================================
+ Coverage 92.50% 93.96% +1.45%
+ Complexity 383 381 -2
============================================
Files 59 59
Lines 1014 1010 -4
============================================
+ Hits 938 949 +11
+ Misses 76 61 -15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.