fix(core): bound unpackValue container nesting depth - #1026
Open
arimu1 wants to merge 1 commit into
Open
Conversation
Add configurable maxNestingDepth on UnpackerConfig (default 512) so deeply nested ARRAY/MAP payloads fail with MessageSizeException instead of StackOverflowError during unpackValue. Fixes msgpack#1015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnpackerConfig.withMaxNestingDepth(int)(default 512) and enforce the limit in bothunpackValue()overloads when recursing into ARRAY/MAP containers.MessageSizeException(aMessagePackException) instead of relying on unbounded JVM recursion.Fixes #1015
Test plan
./sbt "msgpack-core/testOnly org.msgpack.core.NestingDepthLimitTest"./sbt "msgpack-core/testOnly org.msgpack.core.MessagePackTest"(UnpackerConfig equals)./sbt msgpack-core/jcheckStyle