Unified: Fix translation of tuples and grouping exprs - #22551
Draft
asgerf wants to merge 2 commits into
Draft
Conversation
asgerf
commented
Sep 11, 2026
| | test.swift:74:10:74:17 | isSorted | isSorted | | ||
| | test.swift:74:24:74:27 | Bool | Bool | | ||
| | test.swift:75:13:75:13 | i | i | | ||
| | test.swift:75:23:75:27 | count | count | |
Contributor
Author
There was a problem hiding this comment.
This change is because count appeared inside a parenthesis on line 75:
for i in 0..<(count - 1) {
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved critical and moderate findings remain in Swift tuple handling and corpus coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
unified/extractor/src/languages/swift/swift.rs — Regenerate the stale tuple expression corpus fixture |
What changed in this PR
This pull request updates Swift AST translation to structure tuple literals and unwrap ordinary parenthesized expressions.
Changes:
- Translates tuple elements into
argumentchildren. - Removes grouping-expression wrappers.
- Updates QL tests and Swift extractor fixtures.
| File | Summary |
|---|---|
unified/ql/test/library-tests/BasicTest/test.swift |
Adds tuple and grouping-expression cases. |
unified/ql/test/library-tests/BasicTest/test.ql |
Verifies grouping expressions are unwrapped. |
unified/ql/test/library-tests/BasicTest/test.expected |
Updates expected query results. |
unified/extractor/tests/corpus/swift/operators/parenthesised-expression.output |
Updates parenthesized-expression output. |
unified/extractor/tests/corpus/swift/collections/tuple-literal.output |
Updates tuple-literal output. |
unified/extractor/src/languages/swift/swift.rs |
Implements tuple/grouping translation; has critical (1 vote) and moderate (1 vote) unresolved findings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
asgerf
force-pushed
the
unified/tuples
branch
from
September 11, 2026 12:15
cb48872 to
0e5d15d
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are fully reviewed and have no unresolved blocking issues.
Review tier: Lite
Findings: None
Issues resolved since last review (1)
| Severity | Finding |
|---|---|
|
unified/extractor/src/languages/swift/swift.rs — Regenerate the stale tuple expression corpus fixture View resolved comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tuples were accidentally translated into leaf nodes. They are now properly translated into
TupleExpr.The input AST represents parenthesized expressions as unary tuples, so we unfold them. Note that unlike Python, it is not possible to construct a unary tuple in Swift (or at least there is no syntax for it).
Speaking of parenthesized expressions, we'll want to eventually model this similarly to Java, where parentheses are stripped from the AST, and a side table records the number of enclosing parentheses for a given expr (and perhaps the location of the outermost parenthesis pair). The side table can come later; right now we just strip parentheses.