Support structured XMLFOREST arguments with aliases - #2619
Open
minleejae wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XMLFOREST arguments with aliases, such as
XMLFOREST(customer.name AS "Name", balance AS "Balance"), currently fail to parse. Jailer works around this by replacing unsupported XML expressions during SQL analysis (pinned consumer code). Preserving the original expressions and aliases lets consumers inspect and rewrite these queries without discarding their structure.This change implements the XMLFOREST argument syntax using the existing
Functionparameter list and a reusableAliasedExpression. Unaliased arguments retain their existing expression types. Default visitor forwarding preserves compatibility with existing visitors, and a shared renderer keeps model output and custom expression deparsers consistent. Table discovery also traverses aliased arguments, including nested subqueries.Validation: the full Java 17 Gradle
checkpasses, including the zero-conflict JavaCC grammar gate, tests, formatting, Checkstyle, PMD, and SpotBugs. Regression tests cover mixed and nested arguments, quoted aliases, AST mutation, visitor context, custom rendering, table discovery, validation, round trips, legacy XML forms, and rejection of malformed aliases.