Visit pipe expressions through shared deparser paths - #2618
Open
minleejae wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom
ExpressionDeParsercan rewriteSELECT 7while leavingFROM t |> SELECT 7,|> SET a = 7and|> LIMIT 7unchanged. These pipe operators append nested AST nodes directly, bypassing the supplied expression visitor. This makes transformations inconsistent across equivalent ordinary and pipe SQL.Route SELECT and EXTEND items through the existing select-item visitor, reuse the ordinary UPDATE assignment deparser for SET, and visit LIMIT/OFFSET expressions explicitly. This removes duplicate assignment rendering while preserving aliases, tuple brackets and default SQL output.
The downstream investigation found Confluent JDBC's custom deparser overrides explaining why nested expressions must remain reachable through visitors. The pipe cases here are independent upstream reproductions; they are not a claim about Confluent using pipe syntax.
Tests exercise one custom printer across a pipeline, check that each literal is visited once, preserve aliases and the original AST, and round-trip DISTINCT, EXTEND, subqueries, tuple assignments and LIMIT/OFFSET.
Validation: Java 17
./gradlew --console=plain --max-workers=2 check, including all tests and static analysis.